Re: [PATCH v2 1/2] x86/cpu/hygon: Introduce macros for hygon family numbers

* Chaohong Guo <[email protected]> wrote:

> --- /dev/null
> +++ b/arch/x86/include/asm/hygon-family.h
> @@ -0,0 +1,17 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * The helpers to support Hygon CPU specific code path.
> + */
> +
> +#ifndef _ASM_X86_HYGON_FAMILY_H
> +#define _ASM_X86_HYGON_FAMILY_H

Why is the header guard ordering different from <asm/intel-family.h>:

	/* SPDX-License-Identifier: GPL-2.0 */
	#ifndef _ASM_X86_INTEL_FAMILY_H
	#define _ASM_X86_INTEL_FAMILY_H

	/*
	 * "Big Core" Processors (Branded as Core, Xeon, etc...)
	 *

Please follow the standard header guard ordering in
<asm/hygon-family.h> as well.

Thanks,

	Ingo