Re: [PATCH v2 2/2] serial: 8250: Add Airoha SoC UART and HSUART support
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-serial |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Fri, Aug 07, 2026 at 01:54:04AM +0300, Andy Shevchenko wrote: > On Fri, Jul 24, 2026 at 08:30:06PM +0200, Christian Marangi wrote: ... > > + /* Set DLAB to access the baud rate divider registers (BRDH, BRDL) */ > > + serial_port_out(port, UART_LCR, up->lcr | UART_LCR_DLAB); > > + > > + /* Set baud rate calculation defaults (BRDIV ([BRDH,BRDL]) to 1) */ > > + serial_port_out(port, UART_AIROHA_BRDL, UART_BRDL_20M); > > + serial_port_out(port, UART_AIROHA_BRDH, UART_BRDH_20M); > > The above three calls repeat serial8250_do_set_divisor(), don't they? > > /* Set baud rate calculation defaults (BRDIV ([BRDH,BRDL]) to 1) */ > serial8250_do_set_divisor(port, baud, 1); Or with the united definition serial8250_do_set_divisor(port, baud, UART_BRD_20M); -- With Best Regards, Andy Shevchenko