Re: [PATCH 1/2] KVM: TDX: Enable Notify VM exit
"Edgecombe, Rick P" <[email protected]>
| Newsgroups | org.kernel.vger.linux-kernel,org.kernel.vger.kvm |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 2026-08-06 at 06:50 -0700, Sean Christopherson wrote: > > It should be instruction timeout (as is in the SDM). Please reword the > > changelog to refer to the name of the features as they are in the SDM. I.e > > if you search for NOTIFY_VMEXIT or NOTIFY_WINDOW absolutely nothing can be > > found in the SDM. The changelog should ideally mention both - SDM's > > nomenclature and linux's nomenclature. > > No, let's change Linux's nomenclature before merging this, "Notify" was always > vague and confusing. It's unfortunate that we let that bleed into uAPI > headers, but we can simply #define aliases (or just force userspace to update > as well, if they use kernel headers directly). Hmm, ok. We were trying to go with a minimal backport friendly fix. Xiaoyao, if we are going to carve it up, I guess we might as well do the consolidation of the exit handlers too on this version. (a cleanup patch that got left off of this).