Re: [PATCH 1/2] KVM: TDX: Enable Notify VM exit
Sean Christopherson <[email protected]>
| Newsgroups | org.kernel.vger.linux-kernel,org.kernel.vger.kvm |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Aug 07, 2026, Rick P Edgecombe wrote: > On Thu, 2026-08-06 at 06:50 -0700, Sean Christopherson wrote: > > > It should be instruction timeout (as is in the SDM). Please reword the > > > changelog to refer to the name of the features as they are in the SDM. I.e > > > if you search for NOTIFY_VMEXIT or NOTIFY_WINDOW absolutely nothing can be > > > found in the SDM. The changelog should ideally mention both - SDM's > > > nomenclature and linux's nomenclature. > > > > No, let's change Linux's nomenclature before merging this, "Notify" was always > > vague and confusing. It's unfortunate that we let that bleed into uAPI > > headers, but we can simply #define aliases (or just force userspace to update > > as well, if they use kernel headers directly). > > Hmm, ok. We were trying to go with a minimal backport friendly fix. > > Xiaoyao, if we are going to carve it up, I guess we might as well do the > consolidation of the exit handlers too on this version. (a cleanup patch that > got left off of this). Oh, I missed that this was tagged for stable@. Do the mass rename on top. To address Nikolay's concerns, I think a brief blurb at the end calling out that KVM currently uses old terminology would suffice. E.g. Note, KVM uses "pre-production" terminology for the feature formally called Notify VM-Exit. All public versions of the SDM refer to the feature as Instruction Timeout. This will be remedied in the near future, for now, use KVM's terminology for consistency.