Re: [PATCH] checkpatch: add NOKPROBE_SYMBOL to the whitelist of lines that can occur immediately after functions

On Thu, 2026-08-06 at 19:00 -0600, Paul Walmsley wrote:
> It's customary for NOKPROBE_SYMBOL() macro usage to appear immedately

immediate typo.

Andrew can you please fix it when applying?

Anyway, this is completely sensible, thanks.

Acked-by: Joe Perches <[email protected]>

> after a function's final closing brace, but checkpatch doesn't know
> that yet.  As a result, checkpatch --strict incorrectly flags this
> common kernel pattern, e.g.,
> 
> CHECK: Please use a blank line after function/struct/union/enum declarations
> 33: FILE: arch/riscv/kernel/traps.c:273:
>  }
> +NOKPROBE_SYMBOL(probe_single_step_handler);
> 
> Fix by adding NOKPROBE_SYMBOL to the whitelist of patterns that are
> cleared to appear immediately after functions.
> 
> Cc: Nam Cao <[[email protected]](mailto:[email protected])>
> Cc: Jisheng Zhang <[[email protected]](mailto:[email protected])>
> Signed-off-by: Paul Walmsley <[[email protected]](mailto:[email protected])>
> ---
>  scripts/checkpatch.pl | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2b7a42bbdd94..f8a57ed71f34 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4148,6 +4148,7 @@ sub process {
>  		      $line =~ /^\+[a-z_]*init/ ||
>  		      $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
>  		      $line =~ /^\+\s*DECLARE/ ||
> +		      $line =~ /^\+\s*NOKPROBE_SYMBOL/ ||
>  		      $line =~ /^\+\s*builtin_[\w_]*driver/ ||
>  		      $line =~ /^\+\s*__setup/)) {
>  			if (CHK("LINE_SPACING",
> 
> ```