[PATCH] checkpatch: add NOKPROBE_SYMBOL to the whitelist of lines that can occur immediately after functions

Petr Vorel <[email protected]>
Newsgroups org.kernel.vger.linux-kernel
Message-ID <20260810165728.8_Jw_VWUPFMgn9Ah5yGr8upwcMLMa5zLc0Hv02uNCkw@z>
From: Paul Walmsley <[email protected]>

> It's customary for NOKPROBE_SYMBOL() macro usage to appear immedately
> after a function's final closing brace, but checkpatch doesn't know
> that yet.  As a result, checkpatch --strict incorrectly flags this
> common kernel pattern, e.g.,

> CHECK: Please use a blank line after function/struct/union/enum declarations
> 33: FILE: arch/riscv/kernel/traps.c:273:
>  }
> +NOKPROBE_SYMBOL(probe_single_step_handler);

> Fix by adding NOKPROBE_SYMBOL to the whitelist of patterns that are
> cleared to appear immediately after functions.

> Cc: Nam Cao <[email protected]>
> Cc: Jisheng Zhang <[email protected]>
> Signed-off-by: Paul Walmsley <[email protected]>
> ---
>  scripts/checkpatch.pl | 1 +
>  1 file changed, 1 insertion(+)

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2b7a42bbdd94..f8a57ed71f34 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4148,6 +4148,7 @@ sub process {
>  		      $line =~ /^\+[a-z_]*init/ ||
>  		      $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
>  		      $line =~ /^\+\s*DECLARE/ ||
> +		      $line =~ /^\+\s*NOKPROBE_SYMBOL/ ||
>  		      $line =~ /^\+\s*builtin_[\w_]*driver/ ||
>  		      $line =~ /^\+\s*__setup/)) {
>  			if (CHK("LINE_SPACING",

+1

Reviewed-by: Petr Vorel <[email protected]>

Kind regards,
Petr
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.