Re: [PATCH v9 3/3] iio: adc: ti-ads1100: Add ti-ads1110 support to ti-ads1100 driver
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-iio |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Tue, Aug 04, 2026 at 09:28:40PM +0200, Jakub Szczudlo wrote:
> Add ADS1110 support that have faster datarate than ADS1100, it also uses
> internal voltage reference of 2.048V for measurement.
...
> +struct ads1100_config {
> + const char *name;
> + const int *available_data_rate_hz;
We have a trend to make units case-sensitive (as it should have been from
the start), id est _Hz here.
Also no need to resend, hopefully Jonathan can tweak this (and its users).
> + const int data_rate_count;
> + bool has_internal_vref_only;
> +};
--
With Best Regards,
Andy Shevchenko