Re: [PATCH 2/4] iio: imu: bmi270: Match PNP ID found on OneXPlayer X1 Pro (AMD)
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-kernel,org.kernel.vger.linux-iio |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Fri, Jul 31, 2026 at 09:53:23PM +0200, Philip Mueller wrote:
> The OneXPlayer X1 Pro (AMD) uses 10EC5280 rather than BMI0260 or BOSC0260 as PNP ID.
> Adding the ID will enable the BMI260 accelerometer on the device using the bmi270 driver.
...
> /* OrangePi Neo 2026 (since BIOS BCPH01_V1.20), etc. */
> { "BOSC0260", (kernel_ulong_t)&bmi260_chip_info },
> + /* OneXPlayer X1 Pro (AMD), etc. */
> + { "10EC5280", (kernel_ulong_t)&bmi260_chip_info },
Yeah, this is in Realtek PCI scope which ACPI incorporates by
the specification, and yes, I have a long discussion about this
or similar IDs that are misused. If we go this way, this needs
a good shameful comment to point all this creepy choice made by
some unaware vendor(s).
Also, keep it ordered, I think this should go first in the table.
> { }
> };
See also ca2f16c31568 ("Add 10EC5280 to bmi160_i2c ACPI IDs to allow binding on some devices")
for more details.
--
With Best Regards,
Andy Shevchenko