Re: [PATCH v2 2/3] scsi: libsas: Handle errors in sas_set_ex_phy()
John Garry <[email protected]>
| Newsgroups | org.kernel.vger.linux-kernel,org.kernel.vger.linux-scsi |
|---|---|
| Organization | Oracle Corporation |
| Message-ID | <[email protected]> |
On 11/08/2026 17:22, Eshaan Deshmukh wrote:
> if (new_phy) {
> if (WARN_ON_ONCE(test_bit(SAS_HA_ATA_EH_ACTIVE, &ha->state)))
> - return;
> + return 0;
Even though we output the WARN, I am not sure that returning 0 here is
proper. 0 means success, and we have not been successful.