Re: [PATCH v5 2/5] binder: Make shrinker rely solely on per-VMA lock

Suren Baghdasaryan <[email protected]> Wed, 12 Aug 2026 06:37:56 -0700

Newsgroups	org.kernel.vger.linux-kernel,org.kernel.vger.netdev,org.kvack.linux-mm
Message-ID	<CAJuCfpF_3W8BwJ5rqWHABO_2N7Ow8qCbTMacGj8gLTV4mCUy1g@mail.gmail.com>

On Wed, Aug 12, 2026 at 3:46 AM Alice Ryhl <[email protected]> wrote:
>
> On Tue, Aug 11, 2026 at 06:10:52PM -0700, Suren Baghdasaryan wrote:
> >       return LRU_REMOVED_RETRY;
> >
> > -err_invalid_vma:
> >       mutex_unlock(&alloc->mutex);
>
> With the err_invalid_vma label removed, this call to mutex_unlock() is
> no longer reachable as it comes right after a 'return' statement.

Oh, darn! Carlos pointed it out in the previous version and I missed
it again. Sorry about that. I'll remove it, double-check I didn't miss
anything else and repost.
Thanks Alice!

>
> Alice