Re: [PATCH] net: dsa: qca8k: Disable mgmt Ethernet for qca8327

Michał Kępień <[email protected]>
Newsgroups org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID <[email protected]>
> > Could you please point me at the exact retry mechanism you had in mind,
> > either the qca8k one or the Marvell equivalent?  I cannot see any in
> > drivers/net/dsa/qca/qca8k-8xxx.c.  If I'm reading qca8k code correctly,
> > when wait_for_completion_timeout() fails, its return value is just
> > bubbled up the call chain.
> 
> With the mv88e6xxx code, if ethernet times out, i repeated the request
> using MDIO. The code is not in mainline but a few users are using it.

Ah, that way, okay.  It looks like every mgmt Ethernet function in qca8k
has an MDIO fallback path, but I'll keep this in mind, thanks.

> At minimum, i would put a printk() there, and see if it happens.  It
> could be unrelated to your problem...

Ack, thanks.

-- 
Best regards,
Michał Kępień
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.