Re: [PATCH] staging: rtl8723bs: cast EEPROM_DEFAULT_DIFF to s8

Dan Carpenter <[email protected]>
Newsgroups org.kernel.vger.linux-kernel,dev.linux.lists.linux-staging
Message-ID <[email protected]>
On Sat, Aug 15, 2026 at 01:10:30PM -0600, Ivy Lopez wrote:
> EEPROM_DEFAULT_DIFF is defined as the bare integer literal 0xFE
> (254) but is only ever assigned into s8 (signed char) fields used
> to store signed TX power calibration offsets. The implicit
> truncation to -2 is intentional.

Just change it to:

#define EEPROM_DEFAULT_DIFF -2

regards,
dan carpenter
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.