Re: [PATCH v6 3/4] soc: qcom: ubwc: Fix link error when QCOM_SMEM=n
Dmitry Baryshkov <[email protected]>
| Newsgroups | org.kernel.vger.linux-kernel,dev.linux.lists.imx,org.kernel.vger.linux-arm-msm |
|---|---|
| Message-ID | <fk4na2wxwpgqdpy4atzswkovvf6zzthylhvndrc2qqkegfi272@hnydvrjvms57> |
On Mon, Aug 17, 2026 at 03:35:40PM +0300, Daniel Baluta wrote:
> ubwc_config.c calls qcom_smem_is_available() and qcom_smem_dram_get_hbb()
> unconditionally, so QCOM_UBWC_CONFIG=y with QCOM_SMEM=n fails to link:
>
> arm-linux-gnueabihf-ld: ubwc_config.c:(.text+0x2c): undefined
> reference to 'qcom_smem_is_available'
>
> Add the missing 'depends on QCOM_SMEM'.
>
> Fixes: 1b445022d1d0 ("soc: qcom: ubwc: Get HBB from SMEM")
> Reviewed-by: Konrad Dybcio <[email protected]>
> Signed-off-by: Daniel Baluta <[email protected]>
> ---
> drivers/soc/qcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Dmitry Baryshkov <[email protected]>
--
With best wishes
Dmitry