RE: [PATCH net v6 3/4] net: ethernet: oa_tc6: Disable tx queues on fatal error
Selvamani Rajagopal <[email protected]>
| Newsgroups | org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <DM5PR02MB33696A05581D6E113BB0665583A62@DM5PR02MB3369.namprd02.prod.outlook.com> |
> -----Original Message----- > From: Jakub Kicinski <[email protected]> > Subject: Re: [PATCH net v6 3/4] net: ethernet: oa_tc6: Disable tx queues on fatal error > > > Due to a link event? That's a run of the mill situation in drivers > and has to be handled by correctly ordering the events. > I think you shut down the IRQ first, so that's good, not sure if there's > anything else to worry about Agree. If this goes for another version, I can make the comment simple. > > > This use case was raised by AI review during the previous submission, > > which is a valid question. So I thought I should capture this in the > > comment. > > The comment is confusing.