[PATCH 3/3] staging: octeon: remove unnecessary parentheses
Tiago Panizio Gottardo <[email protected]>
| Newsgroups | org.kernel.vger.linux-kernel,dev.linux.lists.linux-staging |
|---|---|
| Message-ID | <CPYP284MB0854FF3AFACD50D8195E9BC5FFA32@CPYP284MB0854.BRAP284.PROD.OUTLOOK.COM> |
Remove unnecessary parentheses from boolean expressions in the RX and TX paths. No functional changes intended. Signed-off-by: Tiago Panizio Gottardo <[email protected]> --- drivers/staging/octeon/ethernet-rx.c | 4 ++-- drivers/staging/octeon/ethernet-tx.c | 20 ++++++++++---------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 5be43bbf6a1d..e3c773e468b5 100644 --- a/drivers/staging/octeon/ethernet-rx.c +++ b/drivers/staging/octeon/ethernet-rx.c @@ -66,7 +66,7 @@ static inline int cvm_oct_check_rcv_error(struct cvmx_wqe *work) else port = work->word1.cn38xx.ipprt; - if ((work->word2.snoip.err_code == 10) && (work->word1.len <= 64)) + if (work->word2.snoip.err_code == 10 && work->word1.len <= 64) /* * Ignore length errors on min size packets. Some * equipment incorrectly pads packets to 64+4FCS @@ -321,7 +321,7 @@ static int cvm_oct_poll(struct oct_rx_group *rx_group, int budget) } packet_not_copied = 0; } - if (likely((port < TOTAL_NUMBER_OF_PORTS) && + if (likely(port < TOTAL_NUMBER_OF_PORTS && cvm_oct_device[port])) { struct net_device *dev = cvm_oct_device[port]; diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c index cc20c1e6791f..f13069d6bd2c 100644 --- a/drivers/staging/octeon/ethernet-tx.c +++ b/drivers/staging/octeon/ethernet-tx.c @@ -154,8 +154,8 @@ netdev_tx_t cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev) * completely remove "qos" in the event neither interface * supports multiple queues per port. */ - if ((CVMX_PKO_QUEUES_PER_PORT_INTERFACE0 > 1) || - (CVMX_PKO_QUEUES_PER_PORT_INTERFACE1 > 1)) { + if (CVMX_PKO_QUEUES_PER_PORT_INTERFACE0 > 1 || + CVMX_PKO_QUEUES_PER_PORT_INTERFACE1 > 1) { qos = GET_SKBUFF_QOS(skb); if (qos <= 0) qos = 0; @@ -225,7 +225,7 @@ netdev_tx_t cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev) * no room to add the padding. The kernel should always give * us at least a cache line */ - if ((skb->len < 64) && OCTEON_IS_MODEL(OCTEON_CN3XXX)) { + if (skb->len < 64 && OCTEON_IS_MODEL(OCTEON_CN3XXX)) { union cvmx_gmxx_prtx_cfg gmx_prt_cfg; int interface = INTERFACE(priv->port); int index = INDEX(priv->port); @@ -360,13 +360,13 @@ netdev_tx_t cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev) dont_put_skbuff_in_hw: /* Check if we can use the hardware checksumming */ - if ((skb->protocol == htons(ETH_P_IP)) && - (ip_hdr(skb)->version == 4) && - (ip_hdr(skb)->ihl == 5) && - ((ip_hdr(skb)->frag_off == 0) || - (ip_hdr(skb)->frag_off == htons(1 << 14))) && - ((ip_hdr(skb)->protocol == IPPROTO_TCP) || - (ip_hdr(skb)->protocol == IPPROTO_UDP))) { + if (skb->protocol == htons(ETH_P_IP) && + ip_hdr(skb)->version == 4 && + ip_hdr(skb)->ihl == 5 && + (ip_hdr(skb)->frag_off == 0 || + ip_hdr(skb)->frag_off == htons(1 << 14)) && + (ip_hdr(skb)->protocol == IPPROTO_TCP || + ip_hdr(skb)->protocol == IPPROTO_UDP)) { /* Use hardware checksum calc */ pko_command.s.ipoffp1 = skb_network_offset(skb) + 1; } -- 2.55.0