Re: [PATCH] devtmpfs: apply mount options to the existing superblock

Greg Kroah-Hartman <[email protected]>
Newsgroups org.kernel.vger.linux-kernel,dev.linux.lists.driver-core,org.kernel.vger.linux-fsdevel
Message-ID <2026082445-illusion-overtake-cacc@gregkh>
On Mon, Aug 24, 2026 at 04:12:53AM +0900, Shigeru Yoshida wrote:
> Commit cb0e0a8bf4e1 ("devtmpfs: replace ->mount with ->get_tree in
> public instance") dropped the reconfigure_single() call that
> public_dev_mount() used to apply the options of every new mount to the
> single, internally created superblock. devtmpfs_get_tree() only takes
> a reference on it: the options are still parsed into fc->fs_private,
> but ->reconfigure is now only reached via reconfigure_super(), i.e. on
> remount, so they are discarded by put_fs_context().
> 
> For example, systemd mounts /dev with "-o mode=755,size=4m,nr_inodes=1m",
> so size= is silently ignored and /dev falls back to the tmpfs default of
> 50% of physical RAM.
> 
> Call the underlying ->reconfigure from devtmpfs_get_tree(), the same
> way tracefs and debugfs do; ramfs has no ->reconfigure, hence the NULL
> check.
> 
> This restores the behaviour of commit a6097180d884 ("devtmpfs
> regression fix: reconfigure on each mount"), which fixed the same
> regression when devtmpfs was first converted away from mount_single().
> 
> Fixes: cb0e0a8bf4e1 ("devtmpfs: replace ->mount with ->get_tree in public instance")
> Cc: [email protected]
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: Shigeru Yoshida <[email protected]>
> ---
>  drivers/base/devtmpfs.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)

Isn't this solved with this series:
	https://lore.kernel.org/r/[email protected]
?

thanks,

greg k-h
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.