Re: [PATCH v3 0/3] clk: qcom: gcc-glymur: Tie the CX power domain to controller

On 8/21/2026 4:04 PM, Pankaj Patil wrote:
> On 8/17/2026 3:40 PM, Konrad Dybcio wrote:
>> On 8/14/26 8:30 AM, Pankaj Patil wrote:
>>> On 7/15/2026 6:59 PM, Abel Vesa wrote:
>>>> The suggestion of having the CX power domain tied up to the GCC
>>>> controller started here:
>>>>
>>>> https://lore.kernel.org/lkml/[email protected]/
>>>>
>>>> and then, for Glymur, it has been brought up here as well:
>>>>
>>>> https://lore.kernel.org/all/[email protected]/
>>>>
>>>> These plus a discussion off-list led to this patchset being done.
>>>>
>>>
>>> This series prevents cx collapse during suspend on recent linux-next tag: next-20260806
>>> Reproducible on latest tag next-20260813 as well
>>
>> Yes and the ""fix"" is to disable the GPU nodes because the custom
>> runtime pm dance done in the gxclkctl driver keeps a vote online
>>
>> That should be fixed instead
>>
>> FWIW ath12k is causing some issues for me in this regard too..
>>
>> Konrad
> 
> There's no need to disable gpu nodes for cx collapse on s2idle, I can reach cx
> collapse after disabling crypto, camcc and evacc nodes along with reverting
> this series, Specifically arm64: dts: qcom: glymur: Add CX power domain to GCC
> Can you share the steps to reproduce? Are you running additional steps before
> triggering suspend?

GCC clock driver on Glymur has gcc_disp_hf_axi_clk marked as
CLK_IS_CRITICAL, doesn't that mean we will always have a vote on CX
with this patch?

Taniya, do you have any insights into why this clock is critical to be
left ON always?

> 
>