Re: [PATCH v2 01/11] dt-bindings: sound: qcom,qaif-cpu: Add binding

On Thu, Jul 2, 2026 at 12:22 PM Krzysztof Kozlowski <[email protected]> wrote:
>
> On Wed, Jul 01, 2026 at 01:04:23PM +0200, Konrad Dybcio wrote:
> > On 7/1/26 12:57 PM, Harendra Gautam wrote:
> > > Add a dt-bindings header for the Qualcomm Audio Interface (QAIF) controller
> > > DAI IDs. This provides shared constants for devicetree sound-dai references
> > > and QAIF aif-interface reg values instead of using raw numeric IDs.
> > >
> > > Add a Devicetree binding for the Qualcomm Audio Interface (QAIF) CPU DAI
> > > controller used on the Shikra audio platform.
> > >
> > > QAIF moves PCM data between system memory and external serial audio
> > > interfaces through the AIF path, and between memory and the internal Bolero
> > > digital codec through the CIF path. The controller needs a binding so
> > > platform Devicetree files can describe its MMIO region, DMA IOMMU stream,
> > > clocks, interrupt, DAI cells and per-interface AIF configuration.
> > >
> > > Describe the single register region, one EE interrupt, the required GCC
> > > LPASS and audio core clocks, the DMA IOMMU mapping, and 'aif-interface@N'
> > > child nodes used for static PCM, TDM or MI2S configuration.
> > >
> > > Depends-on: [PATCH 0/4] clk: qcom: Add Audio Core clock controller
> > >   support on Qualcomm Shikra SoC
> > >   https://lore.kernel.org/linux-clk/[email protected]/
> >
> > This should most definitely not be part of the commit message (which
> > lands in git history..)
>
> And internal review (by tools and/or by people) would tell that, so no
> one ever reviewed this internally. Neither our internal tools did.
>
> Best regards,
> Krzysztof
>
Addressed major comment, will be raising in next patchset.
-Harendra