Re: [PATCH v2 10/11] ASoC: qcom: Add Shikra QAIF support

Harendra Gautam <[email protected]>
Newsgroups org.kernel.vger.linux-kernel,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-sound
Message-ID <CAC-tS8Ct2tSuScAr_cD0_LWSY4HnwaxLnONY4-P=r1o1JF48-g@mail.gmail.com>
On Thu, Jul 2, 2026 at 12:31 PM Krzysztof Kozlowski <[email protected]> wrote:
>
> On Wed, Jul 01, 2026 at 04:27:56PM +0530, Harendra Gautam wrote:
> > +static int shikra_qaif_free_stream_dma_idx(struct qaif_drv_data *drvdata,
> > +                                        int index,
> > +                                        unsigned int dai_id)
> > +{
> > +     switch (dai_id) {
> > +     case QAIF_MI2S_TDM_AIF0 ... QAIF_MI2S_TDM_AIF12:
> > +             clear_bit(index, &drvdata->aif_dma_idx_bit_map);
> > +             break;
> > +     case QAIF_CDC_DMA_RX0 ... QAIF_CDC_DMA_RX9:
> > +     case QAIF_CDC_DMA_TX0 ... QAIF_CDC_DMA_TX9:
> > +     case QAIF_CDC_DMA_VA_TX0 ... QAIF_CDC_DMA_VA_TX9:
> > +             clear_bit(index, &drvdata->cif_dma_idx_bit_map);
> > +             break;
> > +     default:
> > +             break;
> > +     }
> > +
> > +     return 0;
> > +}
> > +
> > +static int shikra_qaif_clk_init(struct platform_device *pdev)
>
> I do not see any response to my comments, so my previous comments stay.
>
> Address the comments and respond to them.
>
> Best regards,
> Krzysztof
>
Address comments, will raise as part of the next patch.
-Harendra
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.