Re: [PATCH net 4/9] net/tls: Honor O_NONBLOCK in tls_sw_splice_read()
Sabrina Dubroca <[email protected]>
| Newsgroups | org.kernel.vger.linux-kselftest,org.kernel.vger.netdev |
|---|---|
| Message-ID | <amsufVx5T-xs9Ydd@krikkit> |
2026-07-26, 20:33:32 -0400, Chuck Lever wrote:
> tls_sw_splice_read() currently derives its blocking behavior from
> SPLICE_F_NONBLOCK alone; the socket's own O_NONBLOCK is invisible
> to it. A splice(2) call without SPLICE_F_NONBLOCK on a nonblocking
Is that needed?
ssize_t do_splice(struct file *in, loff_t *off_in, struct file *out,
loff_t *off_out, size_t len, unsigned int flags)
{
[...]
if ((in->f_flags | out->f_flags) & O_NONBLOCK)
flags |= SPLICE_F_NONBLOCK;
We're not going through do_splice()?
--
Sabrina