Re: [PATCH] selftests/mm: make libnuma-dependent tests optional
"David Hildenbrand (Arm)" <[email protected]>
| Newsgroups | org.kernel.vger.linux-kselftest,org.kernel.vger.linux-kernel,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On 7/30/26 16:27, Jiangshan Yi wrote: > The mm selftests Makefile unconditionally builds three test binaries > that depend on libnuma (migration, ksm_tests, rmap). When libnuma-dev > is not installed, the build fails with a hard error, inconsistent with > how the optional liburing dependency is already handled via > check_config.sh. > > These three tests hard-depend on libnuma at both compile time > (#include <numa.h>) and link time (-lnuma), confirmed by grepping all > .c files under tools/testing/selftests/mm/ for numa.h/numaif.h, which > matches exactly ksm_tests.c, migration.c, and rmap.c. Hi! IIRC, liburing was not universally easily available when we added these changes. libnuma is fairly old. (I might have added that :) ) So why should we bother about setups that don't just want to install libnuma + headers? The real motivation is lacking. -- Cheers, David