Re: [PATCH 09/16] selftests: timers: nanosleep: Explicitly list the tested clocks

John Stultz <[email protected]>
Newsgroups org.kernel.vger.linux-kselftest,org.kernel.vger.linux-kernel
Message-ID <CANDhNCp=aOtw2e3i-XeMbHy8oGfnZ9Waw_n=0Q1Kc_9CbQAF0Q@mail.gmail.com>
On Wed, Jul 29, 2026 at 11:47 PM Thomas Weißschuh (Schneider Electric)
<[email protected]> wrote:
>
> The test relies on the numeric values of the clockids.
> As not all clocks are meant to be tested, this requires skipping some
> clocks unconditionally, cluttering the result.

My only nit here is that there are some clocks the previous code
explicitly skips (_CPUTIME_IDs), and others that are skipped as they
just don't support nanosleep (the _RAW and _COARSE ids) and return the
proper error.

It might be helpful to clarify in the commit message this distinction
so its clear this commit isn't just forgetting the _RAW and _COARSE
ids.


> Use an equivalent, explicit list instead.
>
> Signed-off-by: Thomas Weißschuh (Schneider Electric) <[email protected]>

Otherwise,
Acked-by: John Stultz <[email protected]>

thanks
-john
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.