Re: [PATCH v2] selftests/cgroup: add user_usec sanity check in test_cpucg_nice

Michal Koutný <[email protected]> Fri, 31 Jul 2026 11:18:37 +0200

Newsgroups	org.kernel.vger.linux-kselftest,org.kernel.vger.cgroups,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

On Thu, Jul 30, 2026 at 09:07:17PM +0800, Shaojie Sun <[email protected]> wrote:
> In test_cpucg_nice, after the child process exits, user_usec is
> read from cpu.stat but the value is not checked. Add a sanity check
> to ensure user_usec > 0, analogous to test_cpucg_stats(), so that
> the test fails early if CPU usage wasn't properly accounted.
> 
> Signed-off-by: Shaojie Sun <[email protected]>
> ---
> v2: Instead of simply removing the unused user_usec read, add a sanity
>     check (if user_usec <= 0, goto cleanup) analogous to test_cpucg_stats(),
>     as suggested by Michal.
> 
>  tools/testing/selftests/cgroup/test_cpu.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Michal Koutný <[email protected]>

signature.asc (application/pgp-signature, 265 B)