Re: [PATCH] kunit: tool: fix _list_tests filtering wrong variable when list has TAP prefix
Shuah Khan <[email protected]> Mon, 3 Aug 2026 09:56:06 -0600
| Newsgroups | org.kernel.vger.linux-kselftest,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 7/30/26 06:12, David Gow wrote: > Le 30/07/2026 à 12:19 AM, [email protected] a écrit : >> From: Mohammad Abu-Khader <[email protected]> >> >> `_list_tests()` runs the kernel to list tests, strips printk timestamp >> lines via `extract_tap_lines()`, then drops the dummy TAP header from >> the cleaned `lines`. However the subsequent regex filter mistakenly >> operates on the original `output` instead of the cleaned `lines`. When >> the kernel output includes timestamp prefixes (common with UML or slower >> setups), e.g.: >> >> [ 0.100000] suite.test1 >> [ 0.100000] suite.test2 >> >> the anchored regex `^[^\s.]+\.[^\s.]+$` rejects them and `--list_tests` >> returns an empty list. >> >> Filter `lines` instead of `output`, matching the behavior of the >> adjacent `_list_tests_attr()` which already returns the cleaned list. >> >> Add a regression test with timestamp-prefixed input to verify the fix. >> >> Fixes: 723c8258c8fe ("kunit: tool: Add command line interface to filter and report attributes") Missing Signed-off-by Unfortunately I can't apply this patch. Please fix it and resend. I will try my best to get this into Linux 7.2 thanks, -- Shuah