Re: [PATCH net 1/3] net: hsr: privatize interlink-bound skbs before address mutation

Jakub Kicinski <[email protected]> Mon, 3 Aug 2026 12:43:05 -0700
Newsgroups org.kernel.vger.linux-kselftest,org.kernel.vger.netdev
Message-ID <[email protected]>
On Sat,  1 Aug 2026 03:29:31 +0300 Ali Ahmet Memis wrote:
> The skb_cow() is placed before the address mutation and, thanks to the
> short-circuit, only runs when the interlink skb can alias a live
> consumer: master-originated frames, or ring frames the master also
> consumes (is_local_dest and not is_local_exclusive). The zero-copy ring
> paths keep their behavior. On allocation failure the frame is dropped
> with rx_dropped accounting, matching the tagged-frame creation failure
> path. Reads correctly to me.
> 
> Reviewed-by: Ali Ahmet Memis <[email protected]>

How are you producing this review?
I've never seen this sort of blurb human-written.