Re: [PATCH] selftests: netfilter: Remove unused variables in conntrack_dump_flush

Fernando Fernandez Mancera <[email protected]> Thu, 6 Aug 2026 10:45:10 +0200
Newsgroups org.kernel.vger.linux-kselftest,org.kernel.vger.linux-kernel,org.kernel.vger.netdev,org.kernel.vger.netfilter-devel
Message-ID <[email protected]>
On 8/6/26 9:50 AM, Qingshuang Fu wrote:
> From: Qingshuang Fu <[email protected]>
> 
> The variables 'rplnlh' in conntrack_data_insert() and 'rplnlh' together
> with 'nest' in conntracK_count_zone() and conntrack_flush_zone() were
> declared but never used since they were introduced.
> 
> Similarly, commit 76342e842587 ("selftests: netfilter: remove unused
> parameter") removed the unused 'err' variable from these functions but
> overlooked the remaining unused 'rplnlh' and 'nest' variables.  Remove
> them to clean up the code.
> 
> Fixes: eff3c558bb7e ("netfilter: ctnetlink: support filtering by zone")
> Signed-off-by: Qingshuang Fu <[email protected]>
> ---

Thanks for patch, it looks good to me but could we avoid the fixes tag here?

Reviewed-by: Fernando Fernandez Mancera <[email protected]>