Re: [PATCH net v4 2/4] net: hsr: shrink seqnr_lock to sequence counter updates
Xin Xie <[email protected]>
| Newsgroups | org.kernel.vger.linux-kselftest,org.kernel.vger.linux-kernel,org.kernel.vger.netdev,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On 07/08/2026 16:27, Hangbin Liu wrote: > > Maybe use a shorter commit description. > > Note: Avoid these macros in fast path, prefer per-cpu or per-queue counters. > > And the counters in hsr_deliver_master() also need to protected. Especially > multicast. > > Thanks > Hangbin Thanks. The long commit description was from v4. I reworked and shortened it in v5: https://lore.kernel.org/netdev/[email protected]/ Regarding the statistics, Paolo previously suggested addressing the HSR dev stats races in a separate series, since there are already several occurrences: https://lore.kernel.org/netdev/[email protected]/ Would you prefer that I drop the DEV_STATS_* conversions from the next revision and address all HSR statistics consistently in a follow-up, including hsr_deliver_master() and multicast, rather than adding per-CPU accounting to this series? -- Xin