Re: [RFC PATCH 2/2] KVM: arm64: selftests: Test VGICv3 redistributor region retry
Marc Zyngier <[email protected]>
| Newsgroups | org.kernel.vger.linux-kselftest,dev.linux.lists.kvmarm,org.infradead.lists.linux-arm-kernel,org.kernel.vger.kvm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, 10 Aug 2026 07:52:17 +0100, Karl Mehltretter <[email protected]> wrote: > > The existing redistributor-region test already adds valid partial > regions, rejects a later region that collides with the distributor, and > retries with a valid region. Its guest code does not access a > redistributor, so it misses redistributor MMIO bus entries lost by the > failed rollback. > > Run a guest that reads GICR_TYPER from the second redistributor in the > original region and verifies its processor number. Put the test layout What does test layout mean here? > outside the default guest memory slot so an absent iodev results in a > KVM_EXIT_MMIO instead of an ordinary RAM access. I really hope that accessing an iodev *never* results in RAM access. That'd be... unproductive, at the very least. > > Allow the common VGIC setup helper to select the guest entry point so the > retry case can reuse the normal test setup. [...] This really need to be split. One patch to change the testing infrastructure, another one for whatever new test you want to add. Thanks, M. -- Without deviation from the norm, progress is not possible.