Re: [PATCH v2 4/4] sysctl: Add 0013 to test partially updated vectors

Bradley Morgan <[email protected]>
Newsgroups org.kernel.vger.linux-kselftest,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kvack.linux-mm
Message-ID <[email protected]>
The test covers the parse error, the out of range value and the
first value failing. That's the right coverage.

The shellcheck disable should say why. The test functions are only
called through the dispatch string, so shellcheck thinks they are
unreachable.

run_int_array_no_partial_update() uses spaces for its comment lines
while the code uses tabs.

reset_vals() has no case for int_0003, so sysctl_test_0013 calls it
for nothing. Drop the call or add a case for int_0003.

Nits aside, the test does what it should:

Reviewed-by: Bradley Morgan <[email protected]>
Thanks!
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.