Re: [PATCH bpf v5 2/2] selftests/bpf: allocate a larger timeout for connection

Alexis Lothoré <[email protected]>
Newsgroups org.kernel.vger.linux-kselftest,org.kernel.vger.bpf,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
Hi Daniel,

On Mon Aug 17, 2026 at 10:55 AM CEST, Daniel Borkmann wrote:
> Hi Alexis,
>
> On 8/14/26 9:11 AM, Alexis Lothoré (eBPF Foundation) wrote:

[...]

>> +	/*
>> +	 * If the timeout configured by the test is different from the
>> +	 * connect timeout, restore it
>> +	 */
>> +	if (opts->timeout_ms != CONNECT_MIN_TIMEOUT_MS &&
>> +	    settimeo(fd, opts->timeout_ms)) {
>> +		log_err("Failed to set timeout for connected socket");
>> +		goto close;
>>   	}
>
> Could you do one last spin? I'll get the comment fix applied, but the above
> still has issues as pointed out by sashiko, so maybe this could be reworked
> as follows (untested):

Sure, I was planning to respin today with fixes to issues raised by the
CI bot (wrong patch subject and mishandling of timeouts larger than the
default connect timeout). I'll send it later today.

Thanks,

Alexis

-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.