Re: [PATCH 1/4] net: hsr: fix packet drops caused by GRO superpackets
Xin Xie <[email protected]>
| Newsgroups | org.kernel.vger.linux-kselftest,org.kernel.vger.linux-kernel,org.kernel.vger.netdev,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On 14/08/2026 09:21, Jakub Kicinski wrote: > 1) could you explain in more detail why GRO is breaking things? > GRO shouldn't merge packets with different L2/L2.5 and packets > with trailers? > > 2) the code seems inspired by LRO but LRO also has > NETIF_F_UPPER_DISABLES. This change looks rather incomplete. > Calling it "best effort" seems like an excuse. > > 3) Clashiko has a number of other comments: > https://netdev-ai.bots.linux.dev/sashiko/#/patchset/[email protected] I am currently on annual leave until the middle of September. I will continue this topic when I return. -- Xin