Re: [PATCH net 2/2] selftests: net: tcp_ao: test VRF-scoped key deletion

David Ahern <[email protected]>
Newsgroups org.kernel.vger.linux-kselftest,org.kernel.vger.netdev
Message-ID <[email protected]>
On 8/21/26 9:38 AM, Rastislav Szabo wrote:
> Verify that TCP_AO_DEL_KEY can remove a TCP-AO key scoped to a VRF.
> 
> Assisted-by: Codex:GPT-5
> Signed-off-by: Rastislav Szabo <[email protected]>
> ---
>  .../selftests/net/tcp_ao/key-management.c     | 66 ++++++++++++-------
>  .../testing/selftests/net/tcp_ao/lib/aolib.h  |  6 +-
>  tools/testing/selftests/net/tcp_ao/lib/sock.c |  4 +-
>  3 files changed, 51 insertions(+), 25 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/tcp_ao/key-management.c b/tools/testing/selftests/net/tcp_ao/key-management.c
> index d86bb380b79f..1e01e805dba7 100644
> --- a/tools/testing/selftests/net/tcp_ao/key-management.c
> +++ b/tools/testing/selftests/net/tcp_ao/key-management.c
> @@ -63,7 +63,8 @@ static int prepare_lsk(union tcp_addr *addr, uint8_t sndid, uint8_t rcvid)
>  	return sk;
>  }
>  
> -static int test_del_key(int sk, uint8_t sndid, uint8_t rcvid, bool async,
> +static int test_del_key(int sk, uint8_t sndid, uint8_t rcvid, int ifindex,
> +			bool async,
>  			int current_key, int rnext_key)

The new async can be put on the line with current_key.


Other than that nit:
Reviewed-by: David Ahern <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.