Re: build #310 failed for 2.6.23-rc1-g05ff097 in linux/arch/i386/kernel/apm.c

Hello,

the patch works, now the build completed succesfully. The diff withion the .config files is :

tfoerste@n22 ~/devel/linux-2.6 $ diff .config .config.old
4c4
< # Mon Jul 30 11:47:31 2007
---
> # Mon Jul 30 10:21:20 2007
230a231,237
> CONFIG_APM=y
> # CONFIG_APM_IGNORE_USER_SUSPEND is not set
> CONFIG_APM_DO_ENABLE=y
> # CONFIG_APM_CPU_IDLE is not set
> CONFIG_APM_DISPLAY_BLANK=y
> CONFIG_APM_ALLOW_INTS=y
> CONFIG_APM_REAL_MODE_POWER_OFF=y



Am Montag, 30. Juli 2007 11:40 schrieb Stephen Rothwell:
> On Mon, 30 Jul 2007 10:57:59 +0200 Toralf Förster <[email protected]> wrote:
> >
> > Hello,
> > 
> > the build with the attached .config failed, make ends with:
> > ...
> >   LD      arch/i386/kernel/cpu/built-in.o
> >   CC      arch/i386/kernel/reboot.o
> >   CC      arch/i386/kernel/cpuid.o
> >   CC      arch/i386/kernel/microcode.o
> >   CC      arch/i386/kernel/apm.o
> > arch/i386/kernel/apm.c: In function 'suspend':
> > arch/i386/kernel/apm.c:1211: error: implicit declaration of function 'save_processor_state'
> > arch/i386/kernel/apm.c:1214: error: implicit declaration of function 'restore_processor_state'
> 
> hmm CONFIG_PM_SLEEP was not set.  Can you try the patch below, please?
> 
> > arch/i386/kernel/apm.c: In function 'apm_init':
> > arch/i386/kernel/apm.c:2240: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'u32'
> 
> Someone else has posted a trivial patch for that.
> 
> -- 
> Cheers,
> Stephen Rothwell                    [email protected]
> http://www.canb.auug.org.au/~sfr/
> 
> From: Stephen Rothwell <[email protected]>
> Subject: [PATCH] APM support depend on PM_SLEEP
> 
> Signed-off-by: Stephen Rothwell <[email protected]>
> ---
>  arch/i386/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
> index abb582b..7eefa7d 100644
> --- a/arch/i386/Kconfig
> +++ b/arch/i386/Kconfig
> @@ -938,7 +938,7 @@ source "drivers/acpi/Kconfig"
>  
>  menuconfig APM
>  	tristate "APM (Advanced Power Management) BIOS support"
> -	depends on PM && !X86_VISWS
> +	depends on PM && !X86_VISWS && PM_SLEEP
>  	---help---
>  	  APM is a BIOS specification for saving power using several different
>  	  techniques. This is mostly useful for battery powered laptops with

-- 
MfG/Sincerely

Toralf Förster

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQBGrbV+hyrlCH22naMRAmV/AJ0TKVLcay3uU2q1dpSdCgznZLgsEACgphnL
QvZWmVYyQYcEge2rgz6dkQM=
=7QpZ
-----END PGP SIGNATURE-----