hp6xx: Test APM_DISABLED bit or definition in hp6x0_apm_interrupt()?

Roel Kluin <[email protected]> Fri, 28 Mar 2008 00:35:13 +0100
Newsgroups org.kernel.vger.linux-laptop
Message-ID <[email protected]>
from arch/sh/boards/hp6xx/hp6xx_apm.c:78

static irqreturn_t hp6x0_apm_interrupt(int irq, void *dev)
{
	if (!APM_DISABLED)
		apm_queue_event(APM_USER_SUSPEND);

	return IRQ_HANDLED;
}

shouldn't that be something like

if (!(apm_info.bios.flags & APM_DISABLED))

considering that APM_DISABLED is defined in include/linux/apm_bios.h:153: 
#define APM_DISABLED            0x01