Re: [PATCH v7 7/9] leds: st1202: disable channel when brightness is set to zero

On Thu, 2 Jul 2026, [email protected] wrote:

> Pre-existing issues:
> - [High] The driver assigns the sleeping `st1202_brightness_set` function to the non-blocking `brightness_set` callback, causing 'scheduling while atomic' panics.
> - [High] The `st1202_led_set` function assigned to `brightness_set_blocking` fails to write the actual requested brightness value to the hardware.
> - [High] Saving `fwnode_handle` from a child node without taking a reference inside a scoped iterator leads to a use-after-free.
> - [Medium] The `brightness_get` callback silently drops I2C hardware errors, resulting in incorrect brightness state reporting.
> - [Medium] Global hardware duration registers are corrupted by per-LED pattern changes.

All issues raised are pre-existing and outside the scope of this patch.
They will be addressed in a follow-up submission.

--
Manuel Fombuena