Re: [PATCH v7 9/9] leds: st1202: correct and extend hw_pattern documentation
Manuel Fombuena <[email protected]>
| Newsgroups | org.kernel.vger.linux-leds,dev.linux.lists.sashiko-reviews |
|---|---|
| Message-ID | <GV1PR08MB849734E9341EBAC34E5E45BEC5F42@GV1PR08MB8497.eurprd08.prod.outlook.com> |
On Thu, 2 Jul 2026, [email protected] wrote: > Pre-existing issues: > - [High] Hardware pattern brightness values are not scaled to the 12-bit PWM range, resulting in extremely dim patterns. The documentation update masks this bug by incorrectly blessing the 0-255 range. > - [High] The driver lacks bounds checking for the `repeat` count, leading to silent integer truncation. The documentation update inappropriately enshrines this hardware artifact, breaking API consistency. All issues raised are pre-existing and outside the scope of this patch. They will be addressed in a follow-up submission. -- Manuel Fombuena