Re: [PATCH v3 1/4] dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635
| Newsgroups | org.kernel.vger.linux-leds,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
> The pca9635 supports 16 LED channels, unlike the pca9634 which only > supports 8. The allOf conditional grouped both chips under a single > else branch capping reg at a maximum of 7. > > Give pca9634 its own if/then block and let pca9635 fall through the > else branch with the correct maximum of 15. > > Signed-off-by: Loic Poulain <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1