Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Incomplete refactoring of node name regex in `allOf` conditionals, contradicting commit message.
- [Low] Commit message description starts with a lowercase letter, violating LED subsystem naming conventions.
--
--- Patch [1]: [PATCH v4 1/4] dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635 ---
commit d35db04fcd6edecc8a6a664a044fa839e273b39c
Author: Loic Poulain <[email protected]>
dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635
This commit updates the pca9635 LED controller bindings to support 16 channels
by separating the pca9634 conditional logic. It also sets a default register
maximum of 15 and restricts the node name regex to a single hex digit.
> dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635
[Severity: Low]
This isn't a bug, but the commit message subject starts with a lowercase
letter. The LED subsystem conventions require capitalizing the description
after the prefix. Could this be updated to "Fix reg maximum for pca9635"?
> diff --git a/Documentation/devicetree/bindings/leds/nxp,pca963x.yaml b/Documentation/devicetree/bindings/leds/nxp,pca963x.yaml
> index 938d0e48fe51b..4fda602912f7a 100644
> --- a/Documentation/devicetree/bindings/leds/nxp,pca963x.yaml
> +++ b/Documentation/devicetree/bindings/leds/nxp,pca963x.yaml
[ ... ]
> @@ -88,7 +88,13 @@ allOf:
> properties:
> reg:
> maximum: 3
> - else:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - nxp,pca9634
> + then:
> patternProperties:
> "^led@[0-9a-f]+$":
[Severity: Low]
The commit message states the node name regex was tightened to
"^led@[0-9a-f]$", but it appears the broader "^led@[0-9a-f]+$" regex was left
in place in the allOf conditionals.
While the multi-digit hex nodes will still be rejected globally due to the
root schema, should this conditional and the similar conditional for
nxp,pca9632/pca9633 earlier in the file also be updated to match the commit
message?
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.