Re: [PATCH v5 4/4] arm64: dts: monaco-arduino-monza: microcontroller LEDs

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Use of deprecated `label` property in new LED device tree nodes
--

--- Patch [4]: [PATCH v5 4/4] arm64: dts: monaco-arduino-monza: microcontroller LEDs ---
commit 2e709948eba4cbeeb0ee03878eb97fe42c4fdd87
Author: Loic Poulain <[email protected]>

arm64: dts: monaco-arduino-monza: microcontroller LEDs

This commit adds onboard MCU/STM32 microcontroller LED definitions to the
monaco-arduino-monza device tree. It configures a PCA9635-compatible LED
controller with four RGB LEDs.

> diff --git a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> index 379b796f261f4..83ccc4eec3423 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
[ ... ]
> @@ -156,6 +157,115 @@ vreg_nvme: regulator-3p3-m2 {
[ ... ]
> +&cci1_i2c1 {
> +	led-controller@22 {
> +		compatible = "nxp,pca9635";
[ ... ]
> +		multi-led@0 {
> +			reg = <0>;
> +			label = "stm-led-1";

[Severity: Medium]
Are these label properties necessary?

Since color and function are already defined just below this line, adding the
deprecated label property overrides the standard naming conventions. This
creates sysfs directories like /sys/class/leds/stm-led-1 instead of the
standard color:function format expected by modern user-space LED managers.

Would it be better to omit the label property here and in the multi-led@1,
multi-led@2, and multi-led@3 nodes?

> +			color = <LED_COLOR_ID_RGB>;
> +			function = LED_FUNCTION_STATUS;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4