Re: [PATCH 1/6] [v6] Input: soc_button_array - select CONFIG_GPIOLIB_LEGACY
| Newsgroups | org.kernel.vger.linux-leds,org.kernel.vger.linux-input |
|---|---|
| Message-ID | <[email protected]> |
> From: Arnd Bergmann <[email protected]> > > This driver converts information from ACPI in x86 based tablets and > laptops into platform_data for the gpio_keys driver, using the obsolete > gpio number based interfaces. > > This should really be converted to some other method, but since the > conversion is nontrivial, have this one select GPIOLIB_LEGACY for the > time being. > > This enables turning GPIOLIB_LEGACY off by default on most kernel > builds. Since the driver is only used on x86 portables, add a CONFIG_X86 > dependency, which means non-x86 allmodconfig builds usuallly build > without the legacy gpio support. > > Link: https://lore.kernel.org/all/[email protected]/ > Acked-by: Bartosz Golaszewski <[email protected]> > Acked-by: Dmitry Torokhov <[email protected]> # for input > Signed-off-by: Arnd Bergmann <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1