Re: [PATCH 4/4] arm64: dts: rockchip: Add LincStation E1

> LincStation E1 is an entry-level NAS device powered by the RK3568B2 SoC
> with two 3.5" HDD slots (behind a SATA port multiplier) and two m.2 2280
> slots for SSDs (each PCIe 3.0 x1). Other major features include:
>  - 4 GiB DRAM / 64 GB eMMC
>  - RTL8125 2.5 Gb Ethernet
>  - Fn-Link 6222B-SRC Wi-Fi 5 / Bluetooth module
>  - 1 USB 5 Gbps + 2 USB high speed ports
>  - HDMI output
> 
> Each HDD slot provides a GPIO input for disk presence detection and an
> output for power control. Since the disks are behind a port multiplier,
> there is no way to describe them in the devicetree, so the disk power
> is enabled at all times by GPIO hogs, and the detection inputs are used
> only as LED triggers.
> 
> The board contains several pairs of amber/white LEDs for power, disk,
> m.2 slot, and network status. These are configured to use triggers when
> possible. The PWM fan uses a relatively aggressive fan curve to keep
> the hard disks within a safe temperature range. It may benefit from
> further tuning.
> 
> The pinhole reset button is multiplexed between the SoC reset pin and
> an ADC input. The mux is configured here to drive the SoC reset pin, as
> this works reliably without polling by software. The adc-keys
> description is included for use by a devicetree overlay if desired.
> 
> Signed-off-by: Samuel Holland <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4