Re: [PATCH v4] dt-bindings: leds: Add default-intensity property

Hi Jonas,

Am 14.07.26 um 09:35 schrieb Jonas Rebmann:
> Document the default-intensity property to set a default color on
> multicolor LEDs.
>
> Update pwm-multicolor to support it and update the example to turn the
> LED red on boot.
>
> Acked-by: Conor Dooley <[email protected]>
> Signed-off-by: Jonas Rebmann <[email protected]>
> ---
> Changes in v4:
> - Move default to leds-pwm-multicolor.yaml as other drivers have other
>    defaults (Thanks, Conor)
> - Move definition of default-intensity property next to default-brightness
> - Slighly improve description
> - Link to v3: https://patch.msgid.link/[email protected]
>
> Changes in v3:
> - make default-intensity property description more generic and less
>    redundant (Thanks, Conor)
> - Drop applied patch that introduces the property (Thanks, Lee)
> - Link to v2: https://patch.msgid.link/[email protected]
>
> Changes in v2:
> - dt-bindings: Use correct property name in example
> - dt-bindings: Add missing word in property description
> - Link to v1: https://patch.msgid.link/[email protected]
> ---
>   Documentation/devicetree/bindings/leds/common.yaml              | 9 +++++++++
>   Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 5 +++++
>   2 files changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index f4e44b33f56d..3e6f913070b0 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -179,6 +179,15 @@ properties:
>         initialization. If the option is not set then max brightness is used.
>       $ref: /schemas/types.yaml#/definitions/uint32
>   
> +  default-intensity:
> +    description:
> +      The initial intensity of the LED color component. As the intensity of
> +      each sub-LED is multiplied by the overall brightness, without this
> +      property on a sub-LED, it may effectively be initialized at a brightness
> +      of 0 regardless of its linux,default-trigger and default-brightness
> +      properties.
I have some reservations about the wording. It isn't wrong, but in my 
view, it isn't entirely clear that the initial value depends on the 
implementation.

Maybe something like this?

without this property on a sub-LED, the initial intensity value depends 
on the implementation regardless of its linux,default-trigger and 
default-brightness properties.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +
>     panic-indicator:
>       description:
>         This property specifies that the LED should be used, if at all possible,
> diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> index a31a202afe5c..08e28c5f08a8 100644
> --- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> @@ -45,6 +45,9 @@ properties:
>   
>             color: true
>   
> +          default-intensity:
> +            default: 0
> +
>           required:
>             - pwms
>             - color
> @@ -63,12 +66,14 @@ examples:
>   
>           multi-led {
>               color = <LED_COLOR_ID_RGB>;
> +            linux,default-trigger = "default-on";
>               function = LED_FUNCTION_INDICATOR;
>               max-brightness = <65535>;
>   
>               led-red {
>                   pwms = <&pwm1 0 1000000>;
>                   color = <LED_COLOR_ID_RED>;
> +                default-intensity = <65535>;
>               };
>   
>               led-green {
>
> ---
> base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
> change-id: 20260604-multicolor-default-11e3becde05a
>
> Best regards,
> --
> Jonas Rebmann <[email protected]>
>