Re: [PATCH v7 2/2] leds: ltc3208: Add driver for LTC3208 Multidisplay LED Driver

Uwe Kleine-König <[email protected]> Thu, 16 Jul 2026 16:56:29 +0200

Newsgroups	org.kernel.vger.linux-leds,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID	<aljweARVNZ7PvgSY@monoceros>

Hello,

On Wed, Jul 08, 2026 at 03:00:07PM +0800, Jan Carlo Roleda wrote:
> +#include <linux/bitfield.h>
> +#include <linux/errno.h>
> +#include <linux/i2c.h>
> +#include <linux/leds.h>
> +#include <linux/mod_devicetable.h>

Please don't include this header. The the device-id structs you use are
available via <linux/i2c.h> already.

> +#include <linux/module.h>
> +#include <linux/property.h>
> +#include <linux/regmap.h>
> +#include <linux/types.h>
> [...]
> +static const struct reg_default ltc3208_reg_defaults[LTC3208_REG_G_OPT] = {
> +	{LTC3208_REG_A_GRNRED, 0},
> +	{LTC3208_REG_B_AUXBLU, 0},
> +	{LTC3208_REG_C_MAIN, 0},
> +	{LTC3208_REG_D_SUB, 0},
> +	{LTC3208_REG_E_AUX_SELECT, 0},
> +	{LTC3208_REG_F_CAM, 0},
> +	{LTC3208_REG_G_OPT, 0}

Space after opening { and before } please.

> +};
> [...]
> +	device_for_each_child_node_scoped(&client->dev, child) {
> +		struct ltc3208_led *led;
> +		struct led_init_data init_data = {};

s/{}/{ }/ is the more usual option.

> +		u32 chan;

Best regards
Uwe

signature.asc (application/pgp-signature, 488 B)