Re: [PATCH v23 2/3] rust: leds: add Mode trait

[email protected] Thu, 16 Jul 2026 18:02:38 +0000
Newsgroups org.kernel.vger.linux-leds,org.kernel.vger.linux-pci
Message-ID <[email protected]>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message description is not capitalized.
--

--- Patch [2]: [PATCH v23 2/3] rust: leds: add Mode trait ---
commit 82637721450ea77b83de47ea809b8962d9011425
Author: Markus Probst <[email protected]>

rust: leds: add Mode trait

This commit introduces the led::Mode trait to allow different types of LED
class devices to be used within led::LedOps.

> rust: leds: add Mode trait

[Severity: Low]
This isn't a bug, but the commit message description is not capitalized.
According to the LED subsystem guidelines, the description following the
subsystem prefix must always be capitalized. Could the subject be updated 
to "rust: leds: Add Mode trait" to match standard naming conventions?

-- 
Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2