Re: [PATCH v5] leds: rgb: leds-qcom-lpg: Fix LED color balancing in HW pattern mode
Fenglin Wu <[email protected]> Fri, 17 Jul 2026 11:23:37 +0800
| Newsgroups | org.kernel.vger.linux-leds,dev.linux.lists.sashiko-reviews |
|---|---|
| Message-ID | <[email protected]> |
On 7/16/2026 9:07 PM, Lee Jones wrote: > On Wed, 08 Jul 2026, [email protected] wrote: > >> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: >> >> New issues: >> - [Medium] Mixing goto-based error handling with scope-based cleanup (__free and guard) in the same function. > > Either provide a good explanation or fix please. > Okay. I will update and transfer 'pattern.data' to a '__free(kfree)' local after 'lpg_prepare_pattern()', to get rid of the manual free and goto.