Re: [PATCH RFC v3 04/11] leds: cros_ec: trigger: Implement offloaded() callback
[email protected] Sun, 19 Jul 2026 17:13:02 +0000
| Newsgroups | org.kernel.vger.linux-leds |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The commit message description violates the LED subsystem capitalization and prefix guidelines. -- --- Patch [4]: [PATCH RFC v3 04/11] leds: cros_ec: trigger: Implement offloaded() callback --- commit 0bac1c63d12afa93687a92119005931f3bd9f550 Author: Rong Zhang <[email protected]> leds: cros_ec: trigger: Implement offloaded() callback This commit implements the offloaded() callback for the chromeos-auto private hardware control trigger. The callback always returns true to reflect that it stays in hardware control. > leds: cros_ec: trigger: Implement offloaded() callback [Severity: Low] This isn't a bug, but the commit message subject does not follow the LED subsystem capitalization and prefix guidelines. The standard format requires the description after the subsystem and driver prefix to be capitalized. Could the subject be adjusted to something like "leds: cros_ec: Implement offloaded() trigger callback" to align with the standard format? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=4