Re: [PATCH v10 1/7] dt-bindings: embedded-controller: document ASUS Transformer EC
[email protected] Tue, 21 Jul 2026 09:59:58 +0000
| Newsgroups | org.kernel.vger.linux-leds,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-input |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The `reg` property lacks a `maxItems` constraint or explicit `items` list, which will cause a meta-schema validation failure. -- --- Patch [1]: [PATCH v10 1/7] dt-bindings: embedded-controller: document ASUS Transformer EC --- commit 9a8d6db220adffb6b7bdbf5fea9059f76a4c94f3 Author: Svyatoslav Ryhel <[email protected]> dt-bindings: embedded-controller: document ASUS Transformer EC This commit documents the embedded controller used in the ASUS Transformer device series. It adds a new YAML binding describing the Nuvoton-based controllers attached to an I2C bus. > diff --git a/Documentation/devicetree/bindings/embedded-controller/asus,tf201-ec-pad.yaml b/Documentation/devicetree/bindings/embedded-controller/asus,tf201-ec-pad.yaml > new file mode 100644 > index 0000000000000..60b6375864aaf > --- /dev/null > +++ b/Documentation/devicetree/bindings/embedded-controller/asus,tf201-ec-pad.yaml [ ... ] > + reg: > + description: > + The ASUS Transformer EC has a main I2C address and an associated > + DockRAM device, which provides power-related functions for the > + embedded controller. Both addresses are required for operation. > + minItems: 2 [Severity: Low] Does this reg property also need a maxItems constraint or an explicit items array list? The device tree meta-schema requires standard array properties to be fully bounded to avoid implicitly unbounded arrays, which will likely trigger a failure during make dt_binding_check. [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1