Re: [PATCH v7 2/6] dt-bindings: input: cpcap-pwrbutton: convert to DT schema

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The conversion to YAML format creates broken documentation cross-references between the child power button binding and the parent MFD binding.
--

--- Patch [2]: [PATCH v7 2/6] dt-bindings: input: cpcap-pwrbutton: convert to DT schema ---
commit 04f32d0760614b206c7745dbb0c714f9b7720ee6
Author: Svyatoslav Ryhel <[email protected]>

dt-bindings: input: cpcap-pwrbutton: convert to DT schema

This commit converts the device tree bindings for the Motorola CPCAP PMIC
power button from plain text to YAML format.

> diff --git a/Documentation/devicetree/bindings/input/motorola,cpcap-pwrbutton.yaml b/Documentation/devicetree/bindings/input/motorola,cpcap-pwrbutton.yaml
> new file mode 100644
> index 0000000000000..77a3e5a47d1ae
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/motorola,cpcap-pwrbutton.yaml
> @@ -0,0 +1,32 @@
[ ... ]
> +maintainers:
> +  - Svyatoslav Ryhel <[email protected]>
> +
> +description:
> +  This module is part of the Motorola CPCAP MFD device. For more details
> +  see Documentation/devicetree/bindings/mfd/motorola,cpcap.yaml. The

[Severity: Low]
Are we referencing a file that doesn't exist yet? Since the parent MFD
binding hasn't been converted to YAML yet, the referenced file
motorola,cpcap.yaml doesn't seem to be in the tree.

Additionally, should the parent MFD binding
(Documentation/devicetree/bindings/mfd/motorola-cpcap.txt) be updated in
this patch? It appears it still explicitly lists cpcap-pwrbutton.txt in its
"Optional subnodes:" section, which is being deleted here.

> +  power key is represented as a sub-node of the PMIC node on the device
> +  tree.
> +
> +properties:
> +  compatible:
> +    const: motorola,cpcap-pwrbutton

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2