Re: [PATCH v3 4/4] dt-bindings: leds: backlight: Convert TPS65217 to DT schema

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The patch converts the TPS65217 backlight binding to a comprehensive PMIC schema but fails to delete the existing `regulator/tps65217.txt` binding, resulting in duplicate bindings.
- [Medium] The binding adds interrupt controller capabilities but omits `interrupt-controller` and `#interrupt-cells` from the `required` list.
--

--- Patch [4]: [PATCH v3 4/4] dt-bindings: leds: backlight: Convert TPS65217 to DT schema ---
commit 280c44c9d977e107c7e28a27785e5c9c3dbde99e
Author: Eduard Bostina <[email protected]>

dt-bindings: leds: backlight: Convert TPS65217 to DT schema

This commit converts the Texas Instruments TPS65217 backlight binding to
DT schema, adding child nodes for regulators, charger, and pwrbutton,
as well as documenting interrupt and shutdown controller properties.

> diff --git a/Documentation/devicetree/bindings/leds/backlight/ti,tps65217.yaml b/Documentation/devicetree/bindings/leds/backlight/ti,tps65217.yaml
> new file mode 100644
> index 0000000000000..4d2f4dbd2d52e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/ti,tps65217.yaml
> @@ -0,0 +1,170 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/ti,tps65217.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TPS65217 family of regulators

[Severity: Medium]
This schema defines a comprehensive PMIC with regulators and chargers
rather than just a backlight, but it is placed in the leds/backlight
directory. Should this be moved to a more central MFD or regulator schema
location?

Additionally, it appears the existing regulator binding documentation at
Documentation/devicetree/bindings/regulator/tps65217.txt was not deleted
in this patch, leaving duplicate bindings for the ti,tps65217 compatible
string. Should that file be removed as part of this conversion so schema
validation is not split and inconsistent?

[ ... ]

> +  pwrbutton:
> +    $ref: /schemas/input/ti,tps65217-pwrbutton.yaml#
> +    unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +  - reg

[Severity: Medium]
Because this binding allows the device to act as an interrupt controller,
do interrupt-controller and #interrupt-cells need to be included in this
required list?

The device tree binding guidelines indicate that when hardware provides
these capabilities, the corresponding properties must be required so
incomplete device tree nodes don't silently pass validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4