Re: [PATCH v3 3/4] dt-bindings: input: Convert TI TPS65217 power button to DT schema
Rob Herring <[email protected]> Tue, 21 Jul 2026 10:02:47 -0500
| Newsgroups | org.kernel.vger.linux-leds,dev.linux.lists.sashiko-reviews,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-input |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Jul 21, 2026 at 11:34:07AM +0000, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > > Pre-existing issues: > - [High] Missing NULL check on `dev_get_regmap` can lead to a kernel panic in the IRQ handler. > - [High] The driver incorrectly masks `platform_get_irq()` error codes with `-EINVAL`, breaking probe deferral. > -- Why is sashiko pointing out driver issues on a DT binding patch? This series doesn't even touch the driver. This seems to be a re-occurring problem. Rob